Feat: Update component dropdown when adding/removing a component - #1159
Merged
Conversation
Contributor
Test this pull request
|
alejandralevy
force-pushed
the
feat/update-components-list
branch
from
July 16, 2025 19:16
79f19ad to
aae5087
Compare
Deploying js-sdk-toolchain with
|
| Latest commit: |
0bf39dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fd7a1ddb.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://feat-update-components-list.js-sdk-toolchain.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
==========================================
- Coverage 62.00% 61.84% -0.16%
==========================================
Files 621 621
Lines 20903 20965 +62
Branches 2536 2536
==========================================
+ Hits 12960 12966 +6
- Misses 7501 7557 +56
Partials 442 442 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cyaiox
reviewed
Jul 18, 2025
Comment on lines
+152
to
+154
| if (!isDisabled) { | ||
| return { text: description, ...(link && { link }) } | ||
| } |
Member
There was a problem hiding this comment.
this returned object is the same as the default one... should we send another property here?
cyaiox
approved these changes
Jul 21, 2025
alejandralevy
force-pushed
the
feat/update-components-list
branch
from
July 22, 2025 10:34
32fca88 to
0bf39dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-07-16.at.22.58.55.mov